Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(components): [page-header] use new display tag #12665

Merged
merged 2 commits into from
May 16, 2023
Merged

docs(components): [page-header] use new display tag #12665

merged 2 commits into from
May 16, 2023

Conversation

wzc520pyfm
Copy link
Contributor

@wzc520pyfm wzc520pyfm commented Apr 29, 2023 •
edited

Related: #10754

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@pull-request-triage
Copy link

👋 @wzc520pyfm, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@github-actions
Copy link

Hello @wzc520pyfm, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link

github-actions bot commented Apr 29, 2023 •
edited

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Apr 29, 2023
@github-actions
Copy link

github-actions bot commented Apr 29, 2023 •
edited

🧪 Playground Preview: https://element-plus.run/?pr=12665
Please comment the example via this playground if needed.

chen-ziwen pushed a commit to chen-ziwen/element-plus that referenced this pull request May 10, 2023
fix(components): [comment] add comment (element-plus#12665)
14e59ea
@chenxch chenxch merged commit 798d9d8 into element-plus:dev May 16, 2023
9 checks passed
@wzc520pyfm wzc520pyfm mentioned this pull request Oct 29, 2023
Draft
3 tasks
consultation-applio pushed a commit to consultation-applio/element-plus that referenced this pull request Nov 10, 2023
@wzc520pyfm @dannyhebertbell
docs(components): [page-header] use new display tag (element-plus#12665)
5c2ef5a 
* docs(components): [page-header] use new display tag

* docs(components): [page-header] update title property doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenxch chenxch chenxch left review comments

@ryuhangyeong ryuhangyeong ryuhangyeong approved these changes

Assignees

@wzc520pyfm wzc520pyfm

Labels
CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wzc520pyfm @chenxch @ryuhangyeong