Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(components): [upload] use new display tag #12701

Merged
merged 5 commits into from
Oct 15, 2023

Conversation

wzc520pyfm
Copy link
Contributor

@wzc520pyfm wzc520pyfm commented May 7, 2023

Related: #10754

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

@pull-request-triage
Copy link

👋 @wzc520pyfm, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@github-actions
Copy link

github-actions bot commented May 7, 2023

Hello @wzc520pyfm, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link

github-actions bot commented May 7, 2023

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label May 7, 2023
@github-actions
Copy link

github-actions bot commented May 7, 2023

🧪 Playground Preview: https://element-plus.run/?pr=12701
Please comment the example via this playground if needed.

@btea
Copy link
Collaborator

btea commented Oct 10, 2023

Could you resolve the code conflict? Thanks!

@wzc520pyfm
Copy link
Contributor Author

Could you resolve the code conflict? Thanks!

Thanks for your reminder,I will resolve it tonight.

docs/en-US/component/upload.md Outdated Show resolved Hide resolved
docs/en-US/component/upload.md Outdated Show resolved Hide resolved
docs/en-US/component/upload.md Outdated Show resolved Hide resolved
docs/en-US/component/upload.md Outdated Show resolved Hide resolved
docs/en-US/component/upload.md Outdated Show resolved Hide resolved
Copy link
Member

@tolking tolking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tolking tolking merged commit 40b64df into element-plus:dev Oct 15, 2023
10 checks passed
cc-hearts pushed a commit to cc-hearts/element-plus that referenced this pull request Oct 15, 2023
* docs(components): [upload] use new display tag

* docs(components): [upload] add description for beford-upload

* feat(components): [upload] delete useless attribute

* docs(components): [upload] adjust description and default for attr

* docs(components): [upload] add more detail for data attr
consultation-applio pushed a commit to consultation-applio/element-plus that referenced this pull request Nov 10, 2023
* docs(components): [upload] use new display tag

* docs(components): [upload] add description for beford-upload

* feat(components): [upload] delete useless attribute

* docs(components): [upload] adjust description and default for attr

* docs(components): [upload] add more detail for data attr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants