fix(components): [el-table] rangeWidth dealing with loss of precision #12938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 @lxy030988, seems like this is your first time contribution to element-plus.
|
pull-request-triage
bot
added
1st contribution
|
|
|
Hello @lxy030988, thank you for contributing to element-plus, please see our guideline to see how to make contribution |
github-actions
bot
added
Contribution::Community
CommitMessage::Qualified
|
🧪 Playground Preview: https://element-plus.run/?pr=12938 |
btea
reviewed
May 26, 2023
3 tasks
|
@lxy030988 Could you please update the code with this suggestion? |
lxy030988
force-pushed
the
dev
branch
2 times, most recently
from
71bd55a
to
3ab31b4
Compare
btea
reviewed
Jul 10, 2023
btea
approved these changes
Jul 10, 2023
tolking
approved these changes
Jul 29, 2023
btea
changed the title
|
@lxy030988 Thank you for your contribution! ❤️ |
consultation-applio
pushed a commit
to consultation-applio/element-plus
that referenced
this pull request
Nov 10, 2023
…element-plus#12938) * fix(components): [el-table] rangeWidth use Math.ceil Closes element-plus#12687 * fix(components): [el-table] rangeWidth calculate Closes 12938 * fix(components): [el-table] offsetWidth calculate Closes element-plus#12938
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12687
Please make sure these boxes are checked before submitting your PR, thank you!
devbranch.Description
调整表格的列宽到显示tooltip的临界值（出现省略号），会出现tooltip效果不生效。
造成词现象的原因，rangeWidth 计算使用的四舍五入，丢失零点几像素的宽度。
修改方案：计算 rangeWidth 宽度 使用向上取整。
Related Issue
Fixes #12687
Explanation of Changes