fix(components): [carousel] Watch items causing state loss(#13010) #13011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 @SaberA1ter, seems like this is your first time contribution to element-plus.
|
pull-request-triage
bot
added
1st contribution
|
|
|
Hello @SaberA1ter, thank you for contributing to element-plus, please see our guideline to see how to make contribution |
github-actions
bot
added
Contribution::Community
CommitMessage::Qualified
btea
reviewed
May 31, 2023
|
🧪 Playground Preview: https://element-plus.run/?pr=13011 |
consultation-applio
pushed a commit
to consultation-applio/element-plus
that referenced
this pull request
Nov 10, 2023
…us#13010) (element-plus#13011) * fix(components): [carousel] Watch items causing state loss(element-plus#13010) * perf(components): [carousel] Using the third parameter of watch(element-plus#13010) --------- Co-authored-by: ZZQChongYa <zhengziqiang@star-net.cn>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure these boxes are checked before submitting your PR, thank you!
devbranch.Description
在 carousel 中，
carousel-item 在 onMounted 中向 carousel 中的 items 添加自己，
carousel 添加 watch 去监听 items 变化，每当变化时都会执行
setActiveItem(props.initialIndex)重置当前播放状态activeIndex。这个流程在实际执行中存在问题，他的执行顺序为:
carousel-item onMounted -> 上层 onMounted -> watch items(置为默认状态)这就导致 issue 中翻页失效问题，因为在 watch 中原本应该已经翻页的页数又被重置为 initialIndex。
我将 watch(items) 放在 carousel onMounted 中，但由于 items 的修改在 carousel-item onMounted 又会被触发，所以需要手动设置
activeIndex。最终代码执行顺序:
carousel-item onMounted -> carousel onMounted(置为默认状态) -> 上层 onMounted -> watch items(如果存在变化的话)Related Issue
Fixes #13010 .
Explanation of Changes
🤖 Generated by Copilot at 0f31682
watcheffect foritems.valueinsideonMountedhook and callingsetActiveItem(link)