refactor(components): [image] update class by computed and new docs #13024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 @wzc520pyfm, thank you for contributing element-plus.
|
|
Hello @wzc520pyfm, thank you for contributing to element-plus, please see our guideline to see how to make contribution |
|
|
|
🧪 Playground Preview: https://element-plus.run/?pr=13024 |
ryuhangyeong
approved these changes
Jun 3, 2023
btea
approved these changes
Jun 3, 2023
tolking
approved these changes
Jun 3, 2023
3 tasks
consultation-applio
pushed a commit
to consultation-applio/element-plus
that referenced
this pull request
Nov 10, 2023
…ent-plus#13024) * docs(components): [image and image viewer] use new display tag * refactor(components): [image | image-viewer] set class by computed * docs(components): [image] update head of image viewer exposes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #10754
Please make sure these boxes are checked before submitting your PR, thank you!
devbranch.Description
🤖 Generated by Copilot at 101518a
This pull request enhances the image and image viewer components by improving their documentation, refactoring their code, and fixing some inconsistencies. It updates the
./docs/en-US/component/image.mdfile to match the actual code and usage of the components. It also adds comments, simplifies types, and refactors class bindings in the./packages/components/image-viewer/src/image-viewer.vue,./packages/components/image/src/image.ts,./packages/components/image/src/image.vue, and./packages/components/image-viewer/src/image-viewer.tsfiles.Related Issue
Fixes #___.
Explanation of Changes
🤖 Generated by Copilot at 101518a
zoomRateprop and removeinfiniteprop for image component (link)close-on-press-escapeprop for image viewer component (link)defineExposeto registersetActiveItemexpose for image viewer component (link)docs/en-US/component/image.mdto match code and add default values and type annotations (link, link)loadingattribute indocs/en-US/component/image.md(link)Image Viewer Methodssection toImage Viewer Exposesindocs/en-US/component/image.md(link)