Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): [table] add filteredValue watcher #13121

Merged
merged 4 commits into from
Jul 22, 2023
Merged

fix(components): [table] add filteredValue watcher #13121

merged 4 commits into from
Jul 22, 2023

Conversation

wonderl17
Copy link
Contributor

close #13105

@pull-request-triage
Copy link

👋 @wonderl17, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@github-actions
Copy link

github-actions bot commented Jun 7, 2023

Hello @wonderl17, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link

github-actions bot commented Jun 7, 2023 •
edited

@github-actions
Copy link

github-actions bot commented Jun 7, 2023 •
edited

🧪 Playground Preview: https://element-plus.run/?pr=13121
Please comment the example via this playground if needed.

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Jun 8, 2023
@Karolis-Stoncius
Copy link
Contributor

Hi, when will this be merged?

@Karolis-Stoncius
Copy link
Contributor

I meant when will it be merged into master and released?

@lsjblue
Copy link

lsjblue commented Jul 21, 2023

I need to use it. May I know when it will be released？

@wonderl17
Copy link
Contributor Author

Is there anyone can review this pr?

@Karolis-Stoncius
Copy link
Contributor

@btea

@btea
Copy link
Collaborator

btea commented Jul 22, 2023

@wonderl17 Thank you for your contribution! ❤️

@btea btea merged commit b1572a9 into element-plus:dev Jul 22, 2023
10 checks passed
@element-bot element-bot mentioned this pull request Aug 4, 2023
Merged
3 tasks
@jyj-277
Copy link

jyj-277 commented Aug 30, 2023

image

Has anyone experienced the same error as me? Which occurs when you hold down ctrl+ mouse wheel to zoom.

consultation-applio pushed a commit to consultation-applio/element-plus that referenced this pull request Nov 10, 2023
@wonderl17 @dannyhebertbell
fix(components): [table] add filteredValue watcher (element-plus#13121)
6e9d057
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btea btea btea approved these changes

@ryuhangyeong ryuhangyeong ryuhangyeong approved these changes

@chenxch chenxch Awaiting requested review from chenxch

Assignees

@wonderl17 wonderl17

Labels
CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Component] [table] Table filter selections doesn't update when "filtered-value" changes
6 participants
@wonderl17 @Karolis-Stoncius @lsjblue @btea @jyj-277 @ryuhangyeong