Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components): [dropdown] adjust onItemLeave trigger #13212

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

tolking
Copy link
Member

@tolking tolking commented Jun 14, 2023

closed #13131, closed #12343

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

Description

🤖 Generated by Copilot at 8584cea

Refactored the dropdown component to use a helper function for the trigger prop and to enhance the focus behavior for the popper content.

Related Issue

Fixes #13131.

Explanation of Changes

🤖 Generated by Copilot at 8584cea

  • Simplify the handling of the trigger prop by using ensureArray utility function and a computed property (link, link, link, link)
  • Prevent focusing the popper content when the trigger is not hover to improve accessibility and user experience (link)

@github-actions
Copy link

github-actions bot commented Jun 14, 2023

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Jun 14, 2023
@github-actions
Copy link

🧪 Playground Preview: https://element-plus.run/?pr=13212
Please comment the example via this playground if needed.

@tolking tolking changed the title fix(components): trigger focus change when the trigger includes hover WIP:fix(components): trigger focus change when the trigger includes hover Jun 15, 2023
@tolking tolking changed the title WIP:fix(components): trigger focus change when the trigger includes hover fix(components): trigger focus change when the trigger includes hover Jun 15, 2023
@tolking tolking changed the title fix(components): trigger focus change when the trigger includes hover fix(components): [dropdown] adjust onItemLeave trigger Jun 18, 2023
@btea btea merged commit 9cee967 into dev Aug 22, 2023
13 checks passed
@btea btea deleted the fix/dropdown-item-leave branch August 22, 2023 13:38
@element-bot element-bot mentioned this pull request Aug 25, 2023
3 tasks
laizuan pushed a commit to laizuan/element-plus that referenced this pull request Sep 5, 2023
…13212)

fix(components): trigger focus change when the trigger includes hover

closed element-plus#13131
consultation-applio pushed a commit to consultation-applio/element-plus that referenced this pull request Nov 10, 2023
…13212)

fix(components): trigger focus change when the trigger includes hover

closed element-plus#13131
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CommitMessage::Qualified Qualified commit message
Projects
None yet
3 participants