Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components): [virtual-list] Resetting the vertical scrollbar state #13319

Merged
merged 1 commit into from
Jun 25, 2023

Conversation

huangguangfa
Copy link
Contributor

@huangguangfa huangguangfa commented Jun 21, 2023

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

Description

The code lacks the reset of the vertical scroll bar state when executing the wheel event, it seems to be because 'hScrollbar' is written twice.

🤖 Generated by Copilot at 46be56e

Fix vertical scrollbar bug and enhance virtual-list component. Modify createGrid function in build-grid.ts to update both scrollbars on mouse up.
hScrollbar => vScrollbar

Related Issue

Fixes #___.

Explanation of Changes

🤖 Generated by Copilot at 46be56e

  • Fix vertical scrollbar bug after resizing grid by calling onMouseUp handler of both vScrollbar and hScrollbar in createGrid function (link)

@pull-request-triage
Copy link

👋 @huangguangfa, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@pull-request-triage pull-request-triage bot added 1st contribution Their very first contribution Needs Review labels Jun 21, 2023
@github-actions
Copy link

github-actions bot commented Jun 21, 2023

@github-actions
Copy link

Hello @huangguangfa, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Jun 21, 2023
@github-actions
Copy link

🧪 Playground Preview: https://element-plus.run/?pr=13319
Please comment the example via this playground if needed.

Copy link
Collaborator

@btea btea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@btea btea merged commit 5d2bedc into element-plus:dev Jun 25, 2023
13 checks passed
@element-bot element-bot mentioned this pull request Jul 14, 2023
3 tasks
consultation-applio pushed a commit to consultation-applio/element-plus that referenced this pull request Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants