Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components): [collapse-transition] fixed transition canceled bug #13358

Merged
merged 2 commits into from
Jul 20, 2023

Conversation

kaine0923
Copy link
Contributor

@kaine0923 kaine0923 commented Jun 26, 2023

closed #13357

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

Description

🤖 Generated by Copilot at 25d6fd9

Improved the collapse-transition component by adding functions to handle cancelled transitions and reset the element style. Modified the file collapse-transition.vue to implement these functions.

Related Issue

Fixes #___.

Explanation of Changes

🤖 Generated by Copilot at 25d6fd9

  • Add reset function to restore original style properties of an element after a transition (link)
  • Call reset function when enter or leave transition is cancelled to ensure consistent state of the element (link, link)
  • Add enterCancelled and leaveCancelled hooks to handle transition cancellation events (link, link)

@pull-request-triage
Copy link

👋 @kaine0923, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@pull-request-triage pull-request-triage bot added 1st contribution Their very first contribution Needs Review labels Jun 26, 2023
@github-actions
Copy link

Hello @kaine0923, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link

github-actions bot commented Jun 26, 2023

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Jun 26, 2023
@github-actions
Copy link

github-actions bot commented Jun 26, 2023

🧪 Playground Preview: https://element-plus.run/?pr=13358
Please comment the example via this playground if needed.

Copy link

@biuabiu biuabiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6

Copy link
Collaborator

@btea btea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

@btea btea requested a review from ryuhangyeong July 20, 2023 08:53
@btea btea merged commit d6da5eb into element-plus:dev Jul 20, 2023
10 checks passed
@element-bot element-bot mentioned this pull request Aug 4, 2023
3 tasks
@kaine0923 kaine0923 deleted the collapse-transition-v2 branch October 30, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Component] [collapse-transition] el-collapse-transition点击过快样式会被动画覆盖
4 participants