fix(components): [select] fix the logic of updating selected data #13374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 @inottn, thank you for contributing element-plus.
|
|
|
github-actions
bot
added
Contribution::Community
CommitMessage::Qualified
|
🧪 Playground Preview: https://element-plus.run/?pr=13374 |
|
Excuse me, when will the fix be merged into the dev branch |
|
@btea help review? thx. |
btea
reviewed
Jul 27, 2023
btea
approved these changes
Jul 27, 2023
不合了吗 |
It has been a long time since the first commit. Is there anything else I can do for the merge? Over time, it may be necessary to resolve conflicts, so I hope we can merge as soon as possible. @btea @ryuhangyeong |
tolking
approved these changes
Aug 23, 2023
laizuan
pushed a commit
to laizuan/element-plus
that referenced
this pull request
Sep 5, 2023
…ement-plus#13374) * fix(components): [select] fix the logic of updating selected data * chore: improve judgment condition
consultation-applio
pushed a commit
to consultation-applio/element-plus
that referenced
this pull request
Nov 10, 2023
…ement-plus#13374) * fix(components): [select] fix the logic of updating selected data * chore: improve judgment condition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure these boxes are checked before submitting your PR, thank you!
devbranch.Description
🤖 Generated by Copilot at 9b03904
This pull request improves the select component by adding a test case for options prop changes and preventing unwanted query changes for non-remote or non-filterable selects.
Related Issue
Fixes #13346
Explanation of Changes
🤖 Generated by Copilot at 9b03904