Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme-chalk): [form] remove default width of Input in inline form #13375

Merged
merged 1 commit into from
Jun 30, 2023

Conversation

tolking
Copy link
Member

@tolking tolking commented Jun 27, 2023

Revert #12897

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

Description

🤖 Generated by Copilot at 9f36216

This pull request enhances the documentation and code quality of the Form and Input components. It updates the type and comment of some Form props, adds a FAQ section to the Input documentation, shows how to use CSS variables to control the input width in the inline form example, and removes an unused style rule for the ElInput component.

Related Issue

Fixes #___.

Explanation of Changes

🤖 Generated by Copilot at 9f36216

  • Remove outdated comment about ElInput width issue in inline form documentation (link)
  • Update type annotation of model and scroll-into-view-options props of Form component to use Record<string, any> instead of object (link)
  • Fix typo in closing tag of details element in type declarations documentation (link)
  • Add FAQ section to Input component documentation explaining how to fix width expansion when using clearable prop (link)
  • Add style block to inline form example code demonstrating how to control ElInput width using CSS variables (link)
  • Remove redundant style rule for ElInput width in form.scss (link)

@github-actions
Copy link

github-actions bot commented Jun 27, 2023

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Jun 27, 2023
@tolking tolking requested a review from YunYouJun June 27, 2023 14:09
@github-actions
Copy link

🧪 Playground Preview: https://element-plus.run/?pr=13375
Please comment the example via this playground if needed.

@jeff-fe
Copy link

jeff-fe commented Jun 28, 2023

👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CommitMessage::Qualified Qualified commit message
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants