fix(components): [date-picker] fix the logic of checking the date range #13377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 @inottn, thank you for contributing element-plus.
|
|
|
|
🧪 Playground Preview: https://element-plus.run/?pr=13377 |
|
这个什么时候能合并啊 |
@ryuhangyeong @btea help review? thx. |
btea
approved these changes
Aug 8, 2023
|
And this PR, thx. @btea @ryuhangyeong |
tolking
approved these changes
Aug 23, 2023
HeftyKoo
approved these changes
Aug 24, 2023
laizuan
pushed a commit
to laizuan/element-plus
that referenced
this pull request
Sep 5, 2023
consultation-applio
pushed a commit
to consultation-applio/element-plus
that referenced
this pull request
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure these boxes are checked before submitting your PR, thank you!
devbranch.Description
🤖 Generated by Copilot at b724a20
This pull request enhances the
date-pickercomponent with better validation of date ranges based on thedisabledDateprop. It also adds a test case to verify the new functionality indate-picker.test.ts.Related Issue
Fixes #13373
Explanation of Changes
🤖 Generated by Copilot at b724a20
isValidValueto the panel-date-range component that checks the validity of the selected date range with respect to thedisabledDateprop (link)isValidValuefunction to emit the correct validation result to the parent date-picker component (link)disabledDateprop, verifying that the input value is updated and validated correctly (link)