Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(style): [select] tooltip positioning is incorrect #13424

Merged
merged 1 commit into from
Jul 2, 2023

Conversation

wuzhidexiaoming
Copy link
Contributor

@wuzhidexiaoming wuzhidexiaoming commented Jun 29, 2023

closed #13251
closed #13422

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

Description

When el-select is configured with collapse-tags-tooltip, after the selected tag is displayed in a floating state, the small triangle is positioned incorrectly (not centered) after the tag is deleted

Related Issue

#13251 #13422

Fixes #___.

Explanation of Changes

🤖 Generated by Copilot at 82c59d5

  • Add a ref attribute to the ElTag component inside the ElTooltip component in the select.vue template and expose a function to update the ElTooltip position when a tag is deleted (link, link, link)
  • Define and export a ref to store the ElTooltip instance and a function to delete a tag and update the ElTooltip position in the useSelect.ts file (link, link, link, link)
  • Import and use the ref and the function in the setup function of the select.vue script (link, link)

@pull-request-triage
Copy link

👋 @wuzhidexiaoming, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@pull-request-triage pull-request-triage bot added 1st contribution Their very first contribution Needs Review labels Jun 29, 2023
@github-actions
Copy link

github-actions bot commented Jun 29, 2023

@github-actions
Copy link

Hello @wuzhidexiaoming, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link

github-actions bot commented Jun 29, 2023

🧪 Playground Preview: https://element-plus.run/?pr=13424
Please comment the example via this playground if needed.

@ryuhangyeong ryuhangyeong changed the title fix(style): [select] tooltip positioning is incorrect (#13251 #13422) fix(style): [select] tooltip positioning is incorrect Jul 1, 2023
@btea
Copy link
Collaborator

btea commented Jul 2, 2023

@wuzhidexiaoming Thank you for your contribution!

@btea btea merged commit 4d141a2 into element-plus:dev Jul 2, 2023
10 checks passed
@element-bot element-bot mentioned this pull request Jul 14, 2023
3 tasks
consultation-applio pushed a commit to consultation-applio/element-plus that referenced this pull request Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment