fix: types in exports #13443
Merged
fix: types in exports #13443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 @zhuying547, seems like this is your first time contribution to element-plus.
|
pull-request-triage
bot
added
1st contribution
|
|
|
Hello @zhuying547, thank you for contributing to element-plus, please see our guideline to see how to make contribution |
github-actions
bot
added
Contribution::Community
CommitMessage::Qualified
|
🧪 Playground Preview: https://element-plus.run/?pr=13443 |
YunYouJun
approved these changes
Jul 3, 2023
sxzz
approved these changes
Jul 6, 2023
sxzz
changed the title
consultation-applio
pushed a commit
to consultation-applio/element-plus
that referenced
this pull request
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closed #11818
Please make sure these boxes are checked before submitting your PR, thank you!
devbranch.Description
[TypeScript] Fix TypeScript compilation error caused by import {ElButton} from 'element-plus'
🤖 Generated by Copilot at da01901
Add types field to es modules export map in
package.json. This improves TypeScript support and compatibility for element-plus library.Related Issue
Fixes #11818.
Explanation of Changes
I encountered a TypeScript compilation error when the 'moduleResolution' option in tsconfig.json was set to 'bundler'. The specific error message I received was "TypeScript error TS2614: Module 'element-plus' has no exported member 'ElButton'".
After investigating the issue, I discovered that the error was due to the module resolution strategy specified in the tsconfig.json file. When 'moduleResolution' is set to 'bundler', TypeScript expects the bundled module files to be provided, which may not be the case for the 'element-plus' library.
🤖 Generated by Copilot at da01901