fix(components): fix the attribute conflict #13504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When value is input by shortcut, it's value will not be changed by defaultTime anymore closed element-plus#13483
|
👋 @kamesan012, seems like this is your first time contribution to element-plus.
|
pull-request-triage
bot
added
1st contribution
|
|
|
Hello @kamesan012, thank you for contributing to element-plus, please see our guideline to see how to make contribution |
|
🧪 Playground Preview: https://element-plus.run/?pr=13504 |
btea
reviewed
Jul 20, 2023
packages/components/date-picker/src/date-picker-com/panel-date-pick.vue
Outdated
Show resolved
Hide resolved
btea
reviewed
Jul 20, 2023
packages/components/date-picker/src/date-picker-com/panel-date-pick.vue
Outdated
Show resolved
Hide resolved
Added. |
btea
approved these changes
Jul 21, 2023
|
@btea Does this prrequire two people to review before merging? |
Yes, please be patient. |
tolking
approved these changes
Aug 15, 2023
laizuan
pushed a commit
to laizuan/element-plus
that referenced
this pull request
Sep 5, 2023
* fix(components): fix the attribute conflict When value is input by shortcut, it's value will not be changed by defaultTime anymore closed element-plus#13483 * fix(components): change param to pass the test * fix(components): delete unnecessary changes * fix(components): use let to replace ref variable * fix(components): add test cases
consultation-applio
pushed a commit
to consultation-applio/element-plus
that referenced
this pull request
Nov 10, 2023
* fix(components): fix the attribute conflict When value is input by shortcut, it's value will not be changed by defaultTime anymore closed element-plus#13483 * fix(components): change param to pass the test * fix(components): delete unnecessary changes * fix(components): use let to replace ref variable * fix(components): add test cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When value is input by shortcut, it's value will not be changed by defaultTime anymore
closed #13483
Please make sure these boxes are checked before submitting your PR, thank you!
devbranch.Description
🤖 Generated by Copilot at 146b1df
This change improves the date picker component by allowing shortcut options to emit date values without default time values. It introduces a new parameter
isShortcutto theformatEmitandemitfunctions inpanel-date-pick.vue.Related Issue
Fixes #13483.
Explanation of Changes
🤖 Generated by Copilot at 146b1df
isShortcutparameter toformatEmitandemitfunctions to indicate shortcut date selection (link, link, link)