Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): [row] align="top" is not working properly #13550

Merged
merged 2 commits into from
Jul 22, 2023
Merged

fix(components): [row] align="top" is not working properly #13550

merged 2 commits into from
Jul 22, 2023

Conversation

yj-liuzepeng
Copy link
Contributor

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

Description

the default value of align-items is 'stretch'

Related Issue

Fixes ##13538.

@pull-request-triage
Copy link

👋 @yj-liuzepeng, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@github-actions
Copy link

github-actions bot commented Jul 12, 2023 •
edited

@github-actions
Copy link

Hello @yj-liuzepeng, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link

github-actions bot commented Jul 12, 2023 •
edited

🧪 Playground Preview: https://element-plus.run/?pr=13550
Please comment the example via this playground if needed.

@chenxch
Copy link
Member

chenxch commented Jul 12, 2023

/cc @YunYouJun Should we not set the default value of align like element ui?
image

@YunYouJun
Copy link
Member

Yes, I think we should not set a default value for it.

In addition with the popularity of tailwindcss and unocss today, I think this attribute is no longer needed. 🤣

@yj-liuzepeng yj-liuzepeng mentioned this pull request Jul 12, 2023
Merged
3 tasks
ryuhangyeong
ryuhangyeong reviewed Jul 12, 2023
View reviewed changes
Copy link
Member

@ryuhangyeong ryuhangyeong left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personal Opinion

In my personal opinion, I think it's better to keep the current state because there is no difference in behavior before and after the code change. 🤔

(I think it will have an impact if the align-items: flex-start; property is included, which does not already exist.)

@yj-liuzepeng
Copy link
Contributor Author

Personal Opinion

In my personal opinion, I think it's better to keep the current state because there is no difference in behavior before and after the code change. 🤔

(I think it will have an impact if the align-items: flex-start; property is included, which does not already exist.)

When setting align="top", the effect is different, the previous setting did not take effect.
align-items: flex-start; has been added in row.scss, this property will take effect, please take a look

@yj-liuzepeng
Copy link
Contributor Author

Personal Opinion

In my personal opinion, I think it's better to keep the current state because there is no difference in behavior before and after the code change. 🤔
(I think it will have an impact if the align-items: flex-start; property is included, which does not already exist.)

When setting align="top", the effect is different, the previous setting did not take effect. align-items: flex-start; has been added in row.scss, this property will take effect, please take a look

PTAL @chenxch

@yj-liuzepeng
Copy link
Contributor Author

Is there anything that does not comply with the regulations, why is it not being merged ？🤔️ @btea

@btea
Copy link
Collaborator

btea commented Jul 20, 2023

Is there anything that does not comply with the regulations, why is it not being merged ？🤔️ @btea

Don't worry, it's fine. I just thought it might take @chenxch to confirm.

@btea btea merged commit 49e6cc3 into element-plus:dev Jul 22, 2023
10 checks passed
@element-bot element-bot mentioned this pull request Aug 4, 2023
Merged
3 tasks
@yj-liuzepeng yj-liuzepeng deleted the fix/row-align branch August 16, 2023 15:18
consultation-applio pushed a commit to consultation-applio/element-plus that referenced this pull request Nov 10, 2023
@yj-liuzepeng @dannyhebertbell
fix(components): [row] align="top" is not working properly (element-p…
311d690 
…lus#13550)

* fix(components): [row] align='top' is not working properly

* fix(components): [row] align="top" is not working properly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btea btea btea approved these changes

@ryuhangyeong ryuhangyeong ryuhangyeong approved these changes

@chenxch chenxch Awaiting requested review from chenxch

Assignees

@yj-liuzepeng yj-liuzepeng

Labels
CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@yj-liuzepeng @chenxch @YunYouJun @btea @ryuhangyeong