Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style(theme-chalk): [table] fix th font weight #13556

Merged
merged 1 commit into from
Jul 13, 2023
Merged

style(theme-chalk): [table] fix th font weight #13556

merged 1 commit into from
Jul 13, 2023

Conversation

kaine0923
Copy link
Contributor

@kaine0923 kaine0923 commented Jul 12, 2023 •
edited by ghost

style(theme-chalk): [table] Change th font-weight to 600

style(theme-chalk): [table] remove tag style files

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

Description

🤖 Generated by Copilot at ecff504

Removed unused import of tag style from table component style files, and improved table header appearance by adjusting font-weight.

Related Issue

Fixes #___.

Explanation of Changes

🤖 Generated by Copilot at ecff504

  • Remove unused import of tag component style from table component style to reduce dependencies (link, link)
  • Increase font-weight of table header cells and move it to th selector to improve consistency and visibility (link)

@kaine0923
style(theme-chalk): [table] fix th font weight
ecff504 
style(theme-chalk): [table] change th font weight to 600

style(theme-chalk): [table] remove tag style files
@pull-request-triage
Copy link

👋 @kaine0923, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@pull-request-triage pull-request-triage bot added 1st contribution Their very first contribution Needs Review labels Jul 12, 2023
@github-actions
Copy link

github-actions bot commented Jul 12, 2023 •
edited

@github-actions
Copy link

Hello @kaine0923, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@kaine0923
Copy link
Contributor Author

  1. thead 中的 font-weight 给的是500,但是figma中用的是Semi-Bold。如果font-weight写在thead中会被浏览器的默认样式th中的font-weight: bold 覆盖
  2. el-table中的tag样式好像没有使用到所以我去除了tag相关的样式文件

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Jul 12, 2023
@github-actions
Copy link

🧪 Playground Preview: https://element-plus.run/?pr=13556
Please comment the example via this playground if needed.

@btea btea requested a review from YunYouJun July 12, 2023 12:48
@YunYouJun YunYouJun merged commit a1dd70e into element-plus:dev Jul 13, 2023
13 checks passed
@element-bot element-bot mentioned this pull request Jul 14, 2023
Merged
3 tasks
@kaine0923 kaine0923 deleted the table branch October 30, 2023 11:20
consultation-applio pushed a commit to consultation-applio/element-plus that referenced this pull request Nov 10, 2023
@kaine0923 @dannyhebertbell
style(theme-chalk): [table] fix th font weight (element-plus#13556)
17cfe0e 
style(theme-chalk): [table] change th font weight to 600

style(theme-chalk): [table] remove tag style files

Co-authored-by: kaine <kainewan@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YunYouJun YunYouJun YunYouJun approved these changes

Assignees

@kaine0923 kaine0923

Labels
1st contribution Their very first contribution CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kaine0923 @YunYouJun