Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): [table-v2] calculate the width of MainTable in the same way #13584

Merged
merged 2 commits into from
Aug 15, 2023
Merged

fix(components): [table-v2] calculate the width of MainTable in the same way #13584

merged 2 commits into from
Aug 15, 2023

Conversation

makedopamine
Copy link
Contributor

closes #13520

@pull-request-triage
Copy link

👋 @makedopamine, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@github-actions
Copy link

github-actions bot commented Jul 13, 2023 •
edited

@github-actions
Copy link

Hello @makedopamine, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link

github-actions bot commented Jul 13, 2023 •
edited

🧪 Playground Preview: https://element-plus.run/?pr=13584
Please comment the example via this playground if needed.

ryuhangyeong
ryuhangyeong reviewed Aug 15, 2023
View reviewed changes
Copy link
Member

@ryuhangyeong ryuhangyeong left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@btea

Can you provide a minimal example of the problem under what circumstances? 🙇

@btea
Copy link
Collaborator

btea commented Aug 15, 2023

@ryuhangyeong
before

image

after

image

@tolking tolking merged commit c731027 into element-plus:dev Aug 15, 2023
10 checks passed
@element-bot element-bot mentioned this pull request Aug 25, 2023
Merged
3 tasks
laizuan pushed a commit to laizuan/element-plus that referenced this pull request Sep 5, 2023
@makedopamine @laizuan
fix(components): [table-v2] calculate the width of MainTable in the s…
85905e9 
…ame way (element-plus#13584)

* fix(components): [table-v2] calculate the width of MainTable in the same way

* fix: duplicate properties
consultation-applio pushed a commit to consultation-applio/element-plus that referenced this pull request Nov 10, 2023
@makedopamine @dannyhebertbell
fix(components): [table-v2] calculate the width of MainTable in the s…
dc4e366 
…ame way (element-plus#13584)

* fix(components): [table-v2] calculate the width of MainTable in the same way

* fix: duplicate properties
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tolking tolking tolking approved these changes

@btea btea btea approved these changes

@ryuhangyeong ryuhangyeong ryuhangyeong approved these changes

Assignees

@makedopamine makedopamine

Labels
CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Component] [table-v2] 虚拟表格固定列时宽度计算有误
4 participants
@makedopamine @btea @tolking @ryuhangyeong