fix(components): [tree] fix expand-icon.is-leaf prevent click event #13616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 @matto49, seems like this is your first time contribution to element-plus.
|
pull-request-triage
bot
added
1st contribution
|
|
github-actions
bot
added
Contribution::Community
CommitMessage::Qualified
3 tasks
|
🧪 Playground Preview: https://element-plus.run/?pr=13616 |
|
I'm not sure, maybe I can ask other people for their opinions. cc @YunYouJun @tolking @chenxch |
|
Changes create situations where things behave differently than before. BeforeAfter |
btea
approved these changes
Jul 19, 2023
There was a problem hiding this comment.
@ryuhangyeong Doesn't seem to have any other effect, and it's better to keep the style consistent. 😄
ryuhangyeong
approved these changes
Jul 20, 2023
consultation-applio
pushed a commit
to consultation-applio/element-plus
that referenced
this pull request
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure these boxes are checked before submitting your PR, thank you!
-[x] Make sure you follow contributing guide English | (中文 | Español | Français).
devbranch.Description
unfold icon on leaf-node has wrong cursor although it is hidden.what's more,it covers the leaf-node and make it unable to trigger click event
Related Issue
Fixes #13613.
Explanation of Changes
add visibility:hidden to unfold icon in leaf-node