Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(components): [upload] fix the type of file #13637

Merged
merged 1 commit into from
Jul 22, 2023

Conversation

hhucqian
Copy link
Contributor

@hhucqian hhucqian commented Jul 18, 2023

change the type of UploadRequestOptions.file from File to UploadRawFile

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

Description

🤖 Generated by Copilot at 1a82ee6

Changed the type of file in UploadRequestOptions to UploadRawFile to support different file sources in packages/components/upload/src/upload.ts. This enables the upload function to handle various file inputs and create the corresponding FormData for the request.

Related Issue

Fixes #___.

Explanation of Changes

🤖 Generated by Copilot at 1a82ee6

  • Change the type of the file property in the UploadRequestOptions interface to support different file sources (link)

change the type of UploadRequestOptions.file from File to UploadRawFile
@pull-request-triage
Copy link

👋 @hhucqian, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@pull-request-triage pull-request-triage bot added 1st contribution Their very first contribution Needs Review labels Jul 18, 2023
@github-actions
Copy link

github-actions bot commented Jul 18, 2023

@github-actions
Copy link

Hello @hhucqian, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link

🧪 Playground Preview: https://element-plus.run/?pr=13637
Please comment the example via this playground if needed.

@ryuhangyeong
Copy link
Member

Thank your Contribution!

@ryuhangyeong ryuhangyeong merged commit 708f6ab into element-plus:dev Jul 22, 2023
13 checks passed
@element-bot element-bot mentioned this pull request Aug 4, 2023
3 tasks
consultation-applio pushed a commit to consultation-applio/element-plus that referenced this pull request Nov 10, 2023
change the type of UploadRequestOptions.file from File to UploadRawFile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants