Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: [date-picker] rename time-arrow-control #13651

Merged
merged 2 commits into from
Aug 11, 2023

Conversation

btea
Copy link
Collaborator

@btea btea commented Jul 19, 2023

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

Description

🤖 Generated by Copilot at 0c813da

Removed time-arrow-control prop from date picker and date range components and their documentation. This prop was unnecessary and made the code and UI more complex.

Related Issue

Fixes #13638.

Explanation of Changes

🤖 Generated by Copilot at 0c813da

  • Remove time-arrow-control attribute and prop from el-date-picker and el-time-panel components, as they are no longer supported or needed (link, link, link, link)
  • Remove arrowControl variable from setup functions of panel-date-pick.vue and panel-date-range.vue files, as they are no longer used by the components (link, link)

@github-actions
Copy link

github-actions bot commented Jul 19, 2023

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Jul 19, 2023
@github-actions
Copy link

github-actions bot commented Jul 19, 2023

🧪 Playground Preview: https://element-plus.run/?pr=13651
Please comment the example via this playground if needed.

@btea btea changed the title refactor: [date-picker] remove time-arrow-control refactor: [date-picker] rename time-arrow-control Jul 19, 2023
@btea btea requested a review from ryuhangyeong July 27, 2023 01:33
@btea btea merged commit a8324ca into dev Aug 11, 2023
10 checks passed
@btea btea deleted the refactor/remove-time-arrow-control branch August 11, 2023 12:51
@element-bot element-bot mentioned this pull request Aug 25, 2023
3 tasks
laizuan pushed a commit to laizuan/element-plus that referenced this pull request Sep 5, 2023
* refactor: [date-picker] remove time-arrow-control

* docs: rename time-arrow-control
consultation-applio pushed a commit to consultation-applio/element-plus that referenced this pull request Nov 10, 2023
* refactor: [date-picker] remove time-arrow-control

* docs: rename time-arrow-control
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CommitMessage::Qualified Qualified commit message
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Component] [date-picker] DateTimePicker 的 time-arrow-control 不能正常工作
3 participants