Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): [collapse-transition] remove redundant code #13715

Merged
merged 1 commit into from
Jul 26, 2023
Merged

fix(components): [collapse-transition] remove redundant code #13715

merged 1 commit into from
Jul 26, 2023

Conversation

mhpsy
Copy link
Contributor

@mhpsy mhpsy commented Jul 25, 2023 •
edited by ghost

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

Description

多余的代码，冗余代码清除

copilot:

Related Issue

Fixes #多余的代码，冗余代码清除

Explanation of Changes

🤖 Generated by Copilot at d3230d2

  • Simplify the logic of setting the padding styles for the collapse element by moving the common assignments outside the if-else block (link)

@pull-request-triage
Copy link

👋 @mhpsy, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@pull-request-triage pull-request-triage bot added 1st contribution Their very first contribution Needs Review labels Jul 25, 2023
@github-actions
Copy link

github-actions bot commented Jul 25, 2023 •
edited

@github-actions
Copy link

Hello @mhpsy, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Jul 25, 2023
@github-actions
Copy link

🧪 Playground Preview: https://element-plus.run/?pr=13715
Please comment the example via this playground if needed.

@btea btea changed the title fix(components): [collapse-transition] fix(components): [collapse-transition] remove redundant code Jul 26, 2023
btea
btea approved these changes Jul 26, 2023
View reviewed changes
Copy link
Collaborator

@btea btea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! ❤

@btea btea merged commit 0697a03 into element-plus:dev Jul 26, 2023
13 checks passed
@element-bot element-bot mentioned this pull request Aug 4, 2023
Merged
3 tasks
consultation-applio pushed a commit to consultation-applio/element-plus that referenced this pull request Nov 10, 2023
@mhpsy @dannyhebertbell
fix(components): [collapse-transition] remove redundant code (element…
d6f68af 
…-plus#13715)

fix(components): [collapse-transition]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenxch chenxch chenxch approved these changes

@btea btea btea approved these changes

Assignees

@mhpsy mhpsy

Labels
1st contribution Their very first contribution CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mhpsy @chenxch @btea