Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): [tree] the issue with retrieving childrenKey #13798

Merged
merged 3 commits into from
Aug 7, 2023
Merged

fix(components): [tree] the issue with retrieving childrenKey #13798

merged 3 commits into from
Aug 7, 2023

Conversation

yj-liuzepeng
Copy link
Contributor

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

Related Issue

Fixes #13795.

@pull-request-triage
Copy link

👋 @yj-liuzepeng, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@github-actions
Copy link

Hello @yj-liuzepeng, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link

github-actions bot commented Jul 31, 2023 •
edited

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Jul 31, 2023
@github-actions
Copy link

github-actions bot commented Jul 31, 2023 •
edited

🧪 Playground Preview: https://element-plus.run/?pr=13798
Please comment the example via this playground if needed.

@yj-liuzepeng yj-liuzepeng requested a review from btea August 1, 2023 02:01
@yj-liuzepeng
Copy link
Contributor Author

Could you please review this PR? Thank you very much! @chenxch

@chenxch chenxch merged commit b10eae1 into element-plus:dev Aug 7, 2023
10 checks passed
@btea btea mentioned this pull request Aug 8, 2023
Merged
3 tasks
@yj-liuzepeng yj-liuzepeng deleted the fix/tree-props branch August 16, 2023 15:18
@element-bot element-bot mentioned this pull request Aug 25, 2023
Merged
3 tasks
laizuan pushed a commit to laizuan/element-plus that referenced this pull request Sep 5, 2023
@yj-liuzepeng @laizuan
fix(components): [tree] the issue with retrieving childrenKey (elemen…
9627d0d 
…t-plus#13798)

* fix(components): [tree] the issue with retrieving childrenKey

* Update tree-node.vue

* Update tree-node.vue
consultation-applio pushed a commit to consultation-applio/element-plus that referenced this pull request Nov 10, 2023
@yj-liuzepeng @dannyhebertbell
fix(components): [tree] the issue with retrieving childrenKey (elemen…
e82c0ed 
…t-plus#13798)

* fix(components): [tree] the issue with retrieving childrenKey

* Update tree-node.vue

* Update tree-node.vue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenxch chenxch chenxch approved these changes

@btea btea btea approved these changes

Assignees

@yj-liuzepeng yj-liuzepeng

Labels
CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Component] [tree] tree组件设置了props的children属性不为children时，data更新不会更新ui
3 participants
@yj-liuzepeng @chenxch @btea