-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(components): [collapse] fix accessibility issues #13832
fix(components): [collapse] fix accessibility issues #13832
Conversation
Using tab related aria attributes results in accessibility issues
👋 @Karolis-Stoncius, seems like this is your first time contribution to element-plus.
|
Hello @Karolis-Stoncius, thank you for contributing to element-plus, please see our guideline to see how to make contribution |
🧪 Playground Preview: https://element-plus.run/?pr=13832 |
@btea can you take a look? |
I have limited knowledge of the content related to a11y and may need you to review it. @tolking |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Karolis-Stoncius Based on the problem with #14304, perhaps we should switch back to |
Yeah, this is a feature of form, but changing the |
Yeah, you're right. Changing it back to |
Could you create a new PR to fix it? Thank you! |
Using tab related aria attributes results in accessibility issues
Please make sure these boxes are checked before submitting your PR, thank you!
dev
branch.Description
🤖 Generated by Copilot at fbef87b
The pull request improves the accessibility and semantics of the
collapse
component by using<button>
elements instead of<div>
elements for the collapse item headers, and by adjusting therole
andaria-
attributes accordingly. It also refactors some code and adds some CSS styles to maintain the appearance of the component.Related Issue
Fixes #___.
Explanation of Changes
🤖 Generated by Copilot at fbef87b
<div>
elements with<button>
elements for collapse item headers to improve accessibility and semantics (link, link)role
andaria
attributes from collapse component and collapse item content (link, link)collapse.vue
tocollapse-item.vue
to simplify component structure (link)