-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(docs): [table-v2.md] corrected en-US grammar, spelling, readability #13900
Merged
plainheart
merged 5 commits into
element-plus:dev
from
MilesTails01:documentation-fixes
Aug 10, 2023
Merged
fix(docs): [table-v2.md] corrected en-US grammar, spelling, readability #13900
plainheart
merged 5 commits into
element-plus:dev
from
MilesTails01:documentation-fixes
Aug 10, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👋 @MilesTails01, seems like this is your first time contribution to element-plus.
|
pull-request-triage
bot
added
1st contribution
Their very first contribution
Needs Review
labels
Aug 7, 2023
Hello @MilesTails01, thank you for contributing to element-plus, please see our guideline to see how to make contribution |
github-actions
bot
added
Contribution::Community
CommitMessage::Qualified
Qualified commit message
labels
Aug 7, 2023
🧪 Playground Preview: https://element-plus.run/?pr=13900 |
plainheart
reviewed
Aug 10, 2023
plainheart
reviewed
Aug 10, 2023
plainheart
approved these changes
Aug 10, 2023
laizuan
pushed a commit
to laizuan/element-plus
that referenced
this pull request
Sep 5, 2023
…ty (element-plus#13900) * fix(docs): [table-v2.md] corrected en-US grammar, spelling, readability * fix(docs): [table-v2.md] resolved feedback * fix(docs): [table-v2.md] resolved feedback, further improvements
consultation-applio
pushed a commit
to consultation-applio/element-plus
that referenced
this pull request
Nov 10, 2023
…ty (element-plus#13900) * fix(docs): [table-v2.md] corrected en-US grammar, spelling, readability * fix(docs): [table-v2.md] resolved feedback * fix(docs): [table-v2.md] resolved feedback, further improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
1st contribution
Their very first contribution
CommitMessage::Qualified
Qualified commit message
Contribution::Community
Needs Review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure these boxes are checked before submitting your PR, thank you!
dev
branch.Description
I had a tough time understanding the documentation, so I took some time to spot and fix clear grammar mistakes and tweak the style a bit. I tried to stay close to the original though.
🤖 Generated by Copilot at dd10b59
This pull request improves the documentation of the
table-v2
component by correcting and clarifying the language, and by making the examples and descriptions more consistent and readable.Related Issue
Fixes #___.
Explanation of Changes
I corrected rough mistakes, like missing articles or wrong prepositions. I also enhanced readability by correcting grammar and phrases which were super hard to understand for an english speaking person.
🤖 Generated by Copilot at dd10b59
docs/en-US/component/table-v2.md
(link, link, link)docs/en-US/component/table-v2.md
(link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link)