Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): [table-v2.md] corrected en-US grammar, spelling, readability #13900

Merged
merged 5 commits into from
Aug 10, 2023

Conversation

MilesTails01
Copy link
Contributor

@MilesTails01 MilesTails01 commented Aug 7, 2023

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

Description

I had a tough time understanding the documentation, so I took some time to spot and fix clear grammar mistakes and tweak the style a bit. I tried to stay close to the original though.

🤖 Generated by Copilot at dd10b59

This pull request improves the documentation of the table-v2 component by correcting and clarifying the language, and by making the examples and descriptions more consistent and readable.

Related Issue

Fixes #___.

Explanation of Changes

I corrected rough mistakes, like missing articles or wrong prepositions. I also enhanced readability by correcting grammar and phrases which were super hard to understand for an english speaking person.

🤖 Generated by Copilot at dd10b59

@pull-request-triage
Copy link

👋 @MilesTails01, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@pull-request-triage pull-request-triage bot added 1st contribution Their very first contribution Needs Review labels Aug 7, 2023
@github-actions
Copy link

github-actions bot commented Aug 7, 2023

@github-actions
Copy link

github-actions bot commented Aug 7, 2023

Hello @MilesTails01, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link

github-actions bot commented Aug 8, 2023

🧪 Playground Preview: https://element-plus.run/?pr=13900
Please comment the example via this playground if needed.

docs/en-US/component/table-v2.md Outdated Show resolved Hide resolved
docs/en-US/component/table-v2.md Outdated Show resolved Hide resolved
docs/en-US/component/table-v2.md Outdated Show resolved Hide resolved
@plainheart plainheart enabled auto-merge (squash) August 10, 2023 07:02
@plainheart plainheart merged commit b055a07 into element-plus:dev Aug 10, 2023
10 checks passed
@element-bot element-bot mentioned this pull request Aug 25, 2023
3 tasks
laizuan pushed a commit to laizuan/element-plus that referenced this pull request Sep 5, 2023
…ty (element-plus#13900)

* fix(docs): [table-v2.md] corrected en-US grammar, spelling, readability

* fix(docs): [table-v2.md] resolved feedback

* fix(docs): [table-v2.md] resolved feedback, further improvements
consultation-applio pushed a commit to consultation-applio/element-plus that referenced this pull request Nov 10, 2023
…ty (element-plus#13900)

* fix(docs): [table-v2.md] corrected en-US grammar, spelling, readability

* fix(docs): [table-v2.md] resolved feedback

* fix(docs): [table-v2.md] resolved feedback, further improvements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants