fix(components): [table] add table selection checkbox aria-labels #13908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When checkboxes have no label, it causes accessibility issues. This commit adds aria-labels to table's selection checkboxes
|
👋 @Karolis-Stoncius, seems like this is your first time contribution to element-plus.
|
pull-request-triage
bot
added
1st contribution
|
|
|
Hello @Karolis-Stoncius, thank you for contributing to element-plus, please see our guideline to see how to make contribution |
github-actions
bot
added
Contribution::Community
CommitMessage::Qualified
|
🧪 Playground Preview: https://element-plus.run/?pr=13908 |
ryuhangyeong
reviewed
Aug 9, 2023
Here. Using axe devtool "Form elements must have labels" and "Table header text should not be empty" issues are raised. |
ryuhangyeong
approved these changes
Aug 11, 2023
|
@tolking can you take a look at this? 🙇 |
tolking
approved these changes
Aug 12, 2023
laizuan
pushed a commit
to laizuan/element-plus
that referenced
this pull request
Sep 5, 2023
…ement-plus#13908) When checkboxes have no label, it causes accessibility issues. This commit adds aria-labels to table's selection checkboxes
consultation-applio
pushed a commit
to consultation-applio/element-plus
that referenced
this pull request
Nov 10, 2023
…ement-plus#13908) When checkboxes have no label, it causes accessibility issues. This commit adds aria-labels to table's selection checkboxes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When checkboxes have no label, it causes accessibility issues. This commit adds aria-labels to table's selection checkboxes
Please make sure these boxes are checked before submitting your PR, thank you!
devbranch.Description
🤖 Generated by Copilot at 6b2bae3
Improved accessibility of
selectioncolumn intablecomponent. AddedariaLabelattributes to checkbox elements using column label as value.Related Issue
Fixes #___.
Explanation of Changes
🤖 Generated by Copilot at 6b2bae3
ariaLabelattribute to header and body checkbox elements inselectioncolumn for accessibility (link, link, link)renderHeaderfunction ofselectioncolumn to acceptcolumnparameter with column information (link)