-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(components): [form-label-wrap] use getStyle method #13913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👋 @tiansQAQ, seems like this is your first time contribution to element-plus.
|
pull-request-triage
bot
added
1st contribution
Their very first contribution
Needs Review
labels
Aug 9, 2023
github-actions
bot
added
Contribution::Community
CommitMessage::Qualified
Qualified commit message
labels
Aug 9, 2023
🧪 Playground Preview: https://element-plus.run/?pr=13913 |
btea
approved these changes
Aug 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ryuhangyeong
approved these changes
Aug 9, 2023
@tiansQAQ Thank you for your contribution! ❤️ |
3 tasks
laizuan
pushed a commit
to laizuan/element-plus
that referenced
this pull request
Sep 5, 2023
laizuan
pushed a commit
to laizuan/element-plus
that referenced
this pull request
Sep 5, 2023
element-plus#14106) Revert "refactor(components): [form-label-wrap] use getStyle method (element-plus#13913)" This reverts commit c6a6d9b.
consultation-applio
pushed a commit
to consultation-applio/element-plus
that referenced
this pull request
Nov 10, 2023
consultation-applio
pushed a commit
to consultation-applio/element-plus
that referenced
this pull request
Nov 10, 2023
element-plus#14106) Revert "refactor(components): [form-label-wrap] use getStyle method (element-plus#13913)" This reverts commit c6a6d9b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
1st contribution
Their very first contribution
CommitMessage::Qualified
Qualified commit message
Contribution::Community
Needs Review
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure these boxes are checked before submitting your PR, thank you!
dev
branch.Description
🤖 Generated by Copilot at b59e861
Improved form label component by using
getStyle
utility and adding fallback width. This fixes some cross-browser issues and makes the component more robust.Related Issue
Fixes #___.
Explanation of Changes
🤖 Generated by Copilot at b59e861
getStyle
function from@element-plus/utils
to get the style of an element in a cross-browser compatible way (link, link)