feat(components): [select] add aria-label to select's input #13932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Select's input causes accessibility issues without aria-label, this commit adds it
|
👋 @Karolis-Stoncius, seems like this is your first time contribution to element-plus.
|
pull-request-triage
bot
added
1st contribution
|
|
|
Hello @Karolis-Stoncius, thank you for contributing to element-plus, please see our guideline to see how to make contribution |
github-actions
bot
added
Contribution::Community
CommitMessage::Qualified
btea
reviewed
Aug 10, 2023
|
🧪 Playground Preview: https://element-plus.run/?pr=13932 |
btea
approved these changes
Aug 12, 2023
tolking
reviewed
Aug 24, 2023
tolking
reviewed
Aug 24, 2023
tolking
approved these changes
Aug 24, 2023
laizuan
pushed a commit
to laizuan/element-plus
that referenced
this pull request
Sep 5, 2023
…plus#13932) * feat(components): [select] add aria-label to select's input Select's input causes accessibility issues without aria-label, this commit adds it * refactor(components): [select] change aria-label to label; update docs * refactor(components): [select] change back to ariaLabel prop name * docs(components): kebab-case for docs
consultation-applio
pushed a commit
to consultation-applio/element-plus
that referenced
this pull request
Nov 10, 2023
…plus#13932) * feat(components): [select] add aria-label to select's input Select's input causes accessibility issues without aria-label, this commit adds it * refactor(components): [select] change aria-label to label; update docs * refactor(components): [select] change back to ariaLabel prop name * docs(components): kebab-case for docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Select's input causes accessibility issues without aria-label, this commit adds it
Please make sure these boxes are checked before submitting your PR, thank you!
devbranch.Description
🤖 Generated by Copilot at 104a237
Improve accessibility of
el-selectcomponent by addingaria-labelattributes and a new prop.Related Issue
Fixes #___.
Explanation of Changes
🤖 Generated by Copilot at 104a237
aria-labelattribute toel-inputandel-tagcomponents insideel-selectcomponent to improve accessibility for screen readers (link, link)ariaLabelprop toel-selectcomponent to allow user to pass a custom label for the select component (link)