fix(components): [tree-v2] modify the condition for when the value of currentKey is 0 #13935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 @yj-liuzepeng, thank you for contributing element-plus.
|
|
Hello @yj-liuzepeng, thank you for contributing to element-plus, please see our guideline to see how to make contribution |
|
|
github-actions
bot
added
Contribution::Community
CommitMessage::Qualified
|
🧪 Playground Preview: https://element-plus.run/?pr=13935 |
btea
approved these changes
Aug 10, 2023
ryuhangyeong
approved these changes
Aug 11, 2023
|
@yj-liuzepeng Could you add a test case? |
I'm not familiar with unit testing, but I added a test case. Can you review it, please? @btea |
btea
reviewed
Aug 14, 2023
Co-authored-by: btea <2356281422@qq.com>
Co-authored-by: btea <2356281422@qq.com>
Co-authored-by: btea <2356281422@qq.com>
laizuan
pushed a commit
to laizuan/element-plus
that referenced
this pull request
Sep 5, 2023
… currentKey is 0 (element-plus#13935) * modify the condition for when the value of currentKey is 0 * add a test case * add a test case * add a test case * Update packages/components/tree-v2/__tests__/tree.test.ts Co-authored-by: btea <2356281422@qq.com> * Update packages/components/tree-v2/__tests__/tree.test.ts Co-authored-by: btea <2356281422@qq.com> * Update packages/components/tree-v2/__tests__/tree.test.ts Co-authored-by: btea <2356281422@qq.com> --------- Co-authored-by: btea <2356281422@qq.com>
consultation-applio
pushed a commit
to consultation-applio/element-plus
that referenced
this pull request
Nov 10, 2023
… currentKey is 0 (element-plus#13935) * modify the condition for when the value of currentKey is 0 * add a test case * add a test case * add a test case * Update packages/components/tree-v2/__tests__/tree.test.ts Co-authored-by: btea <2356281422@qq.com> * Update packages/components/tree-v2/__tests__/tree.test.ts Co-authored-by: btea <2356281422@qq.com> * Update packages/components/tree-v2/__tests__/tree.test.ts Co-authored-by: btea <2356281422@qq.com> --------- Co-authored-by: btea <2356281422@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure these boxes are checked before submitting your PR, thank you!
devbranch.Related Issue
Fixes #13933