Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(components): [upload] support async data #14015

Merged
merged 8 commits into from
Sep 8, 2023
Merged

feat(components): [upload] support async data #14015

merged 8 commits into from
Sep 8, 2023

Conversation

jianjunyuu
Copy link
Contributor

@jianjunyuu jianjunyuu commented Aug 20, 2023 •
edited

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

Description

Enhance the data prop of the upload component

Related Issue

Fixes #13925

Explanation of Changes

data: Record<string, any>

to

data: Awaitable<UploadData> | ((rawFile: UploadRawFile) => Awaitable<UploadData>)

@pull-request-triage
Copy link

👋 @jianjunyuu, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@github-actions
Copy link

Hello @jianjunyuu, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link

github-actions bot commented Aug 20, 2023 •
edited

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Aug 20, 2023
@github-actions
Copy link

github-actions bot commented Aug 20, 2023 •
edited

🧪 Playground Preview: https://element-plus.run/?pr=14015
Please comment the example via this playground if needed.

@HeftyKoo
Copy link
Member

Thanks, the change looks good. But some tests do not pass, please take a look later and add this change to the docs.

@jianjunyuu
Copy link
Contributor Author

Thanks, the change looks good. But some tests do not pass, please take a look later and add this change to the docs.

Let's communicate at discard.

@jianjunyuu
Copy link
Contributor Author

Thanks, the change looks good. But some tests do not pass, please take a look later and add this change to the docs.

done.

@HeftyKoo HeftyKoo requested review from tolking and btea August 24, 2023 04:16
@HeftyKoo
Copy link
Member

LGTM

@HeftyKoo HeftyKoo merged commit d96555f into element-plus:dev Sep 8, 2023
10 checks passed
@element-bot element-bot mentioned this pull request Sep 14, 2023
Merged
3 tasks
consultation-applio pushed a commit to consultation-applio/element-plus that referenced this pull request Nov 10, 2023
@jianjunyuu @HeftyKoo @dannyhebertbell
feat(components): [upload] support async data (element-plus#14015)
e16546d 
* feat(components): [upload] support async data

* feat(components): [upload] support async data

* fix(components): [upload] unit test

* fix(components): [upload] unit test

* feat(components): [upload] update data docs

* fix(components): [upload] unit test

* chore: add version

---------

Co-authored-by: Hefty <yeyuqiudeng@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeftyKoo HeftyKoo HeftyKoo approved these changes

@GenerQAQ GenerQAQ GenerQAQ left review comments

@tolking tolking tolking approved these changes

@btea btea Awaiting requested review from btea

Assignees

@jianjunyuu jianjunyuu

Labels
CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
4 participants
@jianjunyuu @HeftyKoo @tolking @GenerQAQ