fix(components): [table] add tabindex to tbody to fix #13991 #14020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 @FrankFang, seems like this is your first time contribution to element-plus.
|
pull-request-triage
bot
added
1st contribution
|
Hello @FrankFang, thank you for contributing to element-plus, please see our guideline to see how to make contribution |
|
|
|
🧪 Playground Preview: https://element-plus.run/?pr=14020 |
btea
reviewed
Aug 22, 2023
btea
approved these changes
Aug 22, 2023
HeftyKoo
reviewed
Aug 24, 2023
HeftyKoo
approved these changes
Aug 28, 2023
|
@FrankFang Thanks! |
3 tasks
consultation-applio
pushed a commit
to consultation-applio/element-plus
that referenced
this pull request
Nov 10, 2023
(element-plus#14020) * fix(components): [table] add tabindex to tbody to fix element-plus#13991 * remove :focus style * fix: remove the focus outline * fix: replace focus with focus-visible * chore: add comments to explain why the tabIndex attr is needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure these boxes are checked before submitting your PR, thank you!
devbranch.Description
🤖 Generated by Copilot at 681e5ca
Fixed the unwanted outline of the table body when focused by setting
tabIndexto -1 and removing the outline style. This improved the design and accessibility of thetablecomponent.Related Issue
Fixes #13991.
Explanation of Changes
🤖 Generated by Copilot at 681e5ca