fix(components): [form] improve types #14062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 @ModyQyW, thank you for contributing element-plus.
|
|
|
|
🧪 Playground Preview: https://element-plus.run/?pr=14062 |
tolking
approved these changes
Aug 28, 2023
btea
reviewed
Aug 30, 2023
btea
reviewed
Aug 30, 2023
btea
approved these changes
Aug 30, 2023
consultation-applio
pushed a commit
to consultation-applio/element-plus
that referenced
this pull request
Nov 10, 2023
* fix(components): [form] improve types * docs: update form * fix: consider RegExp * chore: update jsdoc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure these boxes are checked before submitting your PR, thank you!
devbranch.Description
In #12549 we introduced an optional generic support. However, it doesn't consider
Date,File, .etc. This PR fixes the problem and updates the doc.🤖 Generated by Copilot at f25fed6
Improved the type definitions and documentation for form validation rules. Added support for native objects and nested fields using
PathandFieldPathtypes inpackages/components/form/src/types.tsanddocs/en-US/component/form.md.Related Issue
/
Explanation of Changes
This PR considers
Date,File,FileList, andBlob. Should be an improve.🤖 Generated by Copilot at f25fed6
FormRulestype to support nested fields and tuples (link, link, link, link)