Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components): [color-picker] exposed show method wrong behavior #14064

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

wonderl17
Copy link
Contributor

@wonderl17 wonderl17 commented Aug 23, 2023

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

Description

🤖 Generated by Copilot at 9fda852

Improved the responsiveness of the color picker component by using the leading option of the debounce function in color-picker.vue. This change is part of a pull request that fixes various color picker issues.

Related Issue

Fixes #14049_.

Explanation of Changes

🤖 Generated by Copilot at 9fda852

  • Improve the user experience of the color picker component by making it show up faster on the first click (link)

@pull-request-triage
Copy link

👋 @wonderl17, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@github-actions
Copy link

github-actions bot commented Aug 23, 2023

@github-actions
Copy link

Hello @wonderl17, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link

🧪 Playground Preview: https://element-plus.run/?pr=14064
Please comment the example via this playground if needed.

@wonderl17
Copy link
Contributor Author

🧪 Playground Preview: https://element-plus.run/?pr=14064 Please comment the example via this playground if needed.

Playground

Copy link
Collaborator

@btea btea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wonderl17
Copy link
Contributor Author

Hi~Can this PR be merged?

@btea btea merged commit 0a46c24 into element-plus:dev Oct 9, 2023
13 checks passed
@element-bot element-bot mentioned this pull request Oct 13, 2023
3 tasks
cc-hearts pushed a commit to cc-hearts/element-plus that referenced this pull request Oct 15, 2023
…lement-plus#14064)

fix(components): [color-picker] fix show method wrong behavior
consultation-applio pushed a commit to consultation-applio/element-plus that referenced this pull request Nov 10, 2023
…lement-plus#14064)

fix(components): [color-picker] fix show method wrong behavior
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Component] [color-picker] trigger color picker with show by expose, but it will hide immediately
3 participants