Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(components): [el-pagination] add teleported prop #14072

Merged
merged 5 commits into from
Sep 6, 2023

Conversation

boomboy4
Copy link
Contributor

@boomboy4 boomboy4 commented Aug 24, 2023

分页组件新增teleported参数 默认为true 便于用户控制size下拉框是否插入body

closed #14070

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

Description

🤖 Generated by Copilot at 4a7e171

Added a teleported prop to the ElPagination and ElPaginationSizes components to enable or disable teleporting the pagination size component to the body element. This improves the flexibility and usability of the pagination component.

Related Issue

Fixes #___.

Explanation of Changes

🤖 Generated by Copilot at 4a7e171

  • Add a new prop teleported to control the teleportation of the pagination size component (link, link)
  • Pass the teleported prop from the ElPagination component to the ElPaginationSizes component in the template and the script (link, link)
  • Set the default value of the teleported prop to true for the ElPagination component (link)

分页组件新增teleported参数 默认为true  便于用户控制size下拉框是否插入body

closed element-plus#14070
@pull-request-triage
Copy link

👋 @boomboy4, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@pull-request-triage pull-request-triage bot added 1st contribution Their very first contribution Needs Review labels Aug 24, 2023
@github-actions
Copy link

Hello @boomboy4, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link

github-actions bot commented Aug 24, 2023

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Aug 25, 2023
@github-actions
Copy link

github-actions bot commented Aug 25, 2023

🧪 Playground Preview: https://element-plus.run/?pr=14072
Please comment the example via this playground if needed.

change the default value of teleported to true
@btea btea changed the title fix(components): [el-pagination] 修复toplayer全屏模式下分页下拉框无法显示问题 feat(components): [el-pagination] add teleported prop Sep 1, 2023
Copy link
Collaborator

@btea btea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Co-authored-by: qiang <qw13131wang@gmail.com>
Copy link
Member

@tolking tolking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank for your contribution

@tolking tolking enabled auto-merge (squash) September 5, 2023 04:18
@tolking tolking merged commit 9a60a90 into element-plus:dev Sep 6, 2023
10 checks passed
@element-bot element-bot mentioned this pull request Sep 14, 2023
3 tasks
consultation-applio pushed a commit to consultation-applio/element-plus that referenced this pull request Nov 10, 2023
…4072)

* fix(components): [pagination] 修复toplayer全屏模式下分页下拉框无法显示问题

分页组件新增teleported参数 默认为true  便于用户控制size下拉框是否插入body

closed element-plus#14070

* docs(docs): [pagination] Add a teleported attribute

closed element-plus#14070

* fix(components): [pagination] teleported props default value

delete set teleported default value

closed element-plus#14070

* fix(components): [pagination] change the default value of teleported

change the default value of teleported to true

* Update docs/en-US/component/pagination.md

Co-authored-by: qiang <qw13131wang@gmail.com>

---------

Co-authored-by: shaojia.cheng <shaojia.cheng@arvetech.net>
Co-authored-by: qiang <qw13131wang@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Component] [pagination] toplayer全屏模式下分页下拉框无法显示
3 participants