Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components): [select] gurad value type error #14074

Merged
merged 1 commit into from
Aug 28, 2023
Merged

Conversation

sseinHu
Copy link
Contributor

@sseinHu sseinHu commented Aug 24, 2023

select In the case of radio, the packaged code will report select. slice is not a function, because the radio selected is an object, and the object does not have the api of slice

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

Description

🤖 Generated by Copilot at 4655cc6

Fixed a bug that caused tags to appear in single mode select component. Modified showTagList and collapseTagList in useSelect.ts to respect the multiple prop.

Related Issue

Fixes #___.

Explanation of Changes

🤖 Generated by Copilot at 4655cc6

  • Fix tag display bug for select component in single mode (link)

select In the case of radio, the packaged code will report select. slice is not a function, because the radio selected is an object, and the object does not have the api of slice
@pull-request-triage
Copy link

👋 @sseinHu, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@pull-request-triage pull-request-triage bot added 1st contribution Their very first contribution Needs Review labels Aug 24, 2023
@github-actions
Copy link

Hello @sseinHu, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link

github-actions bot commented Aug 24, 2023

@sseinHu
Copy link
Contributor Author

sseinHu commented Aug 24, 2023

Please fix this problem as soon as possible, it has seriously affected my project

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Aug 25, 2023
@github-actions
Copy link

🧪 Playground Preview: https://element-plus.run/?pr=14074
Please comment the example via this playground if needed.

@btea btea changed the title fix(components): [useSelect.ts] selected.slice is not a function fix(components): [select] gurad value type error Aug 25, 2023
@btea btea requested a review from kooriookami August 25, 2023 08:17
@sseinHu
Copy link
Contributor Author

sseinHu commented Aug 25, 2023

May I ask when this problem can be fixed and released?

@btea
Copy link
Collaborator

btea commented Aug 26, 2023

Referring to the comment on #14071 , I think this is acceptable, do you think? @kooriookami

@kooriookami
Copy link
Member

Referring to the comment on #14071 , I think this is acceptable, do you think? @kooriookami

I agree with it.

@btea
Copy link
Collaborator

btea commented Aug 28, 2023

May I ask when this problem can be fixed and released?

At present, it has entered a relatively stable version, so the release time interval may be relatively longer, about three to four weeks.

@btea btea merged commit e5ebf80 into element-plus:dev Aug 28, 2023
13 checks passed
@sseinHu
Copy link
Contributor Author

sseinHu commented Aug 28, 2023

May I ask when this problem can be fixed and released?

At present, it has entered a relatively stable version, so the release time interval may be relatively longer, about three to four weeks.

Hello, you can merge and release it this week, the version requirements will start to be tested this week, thank you.

@btea
Copy link
Collaborator

btea commented Aug 29, 2023

Sorry, there should be no release plan for this week. Maybe you can temporarily use patch-package to solve it.

@sseinHu
Copy link
Contributor Author

sseinHu commented Sep 11, 2023

Sorry, there should be no release plan for this week. Maybe you can temporarily use patch-package to solve it.

Hello, may I ask how long it will take to publish this question?

@element-bot element-bot mentioned this pull request Sep 14, 2023
3 tasks
@btea
Copy link
Collaborator

btea commented Sep 15, 2023

@sseinHu The latest version has been released, you can try it.

consultation-applio pushed a commit to consultation-applio/element-plus that referenced this pull request Nov 10, 2023
fix(components): [useSelect.ts] selected.slice is not a function

select In the case of radio, the packaged code will report select. slice is not a function, because the radio selected is an object, and the object does not have the api of slice
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants