Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components): [rate] bind the textColor property #14092

Merged
merged 5 commits into from
Aug 28, 2023

Conversation

yj-liuzepeng
Copy link
Contributor

@yj-liuzepeng yj-liuzepeng commented Aug 25, 2023

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

Description

🤖 Generated by Copilot at 4ade99d

Added a new prop textColor to the rate component to enable customizing the text color. Modified rate.vue to apply the prop value to the text style.

Related Issue

Fixes #14091

Explanation of Changes

🤖 Generated by Copilot at 4ade99d

  • Add textColor prop to rate component to customize text color (link)
  • Bind textColor prop value to span element style attribute (link)

@pull-request-triage
Copy link

👋 @yj-liuzepeng, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@github-actions
Copy link

github-actions bot commented Aug 25, 2023

@github-actions
Copy link

Hello @yj-liuzepeng, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link

github-actions bot commented Aug 25, 2023

🧪 Playground Preview: https://element-plus.run/?pr=14092
Please comment the example via this playground if needed.

Copy link
Collaborator

@btea btea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default value in the documentation should be changed to ''.

@yj-liuzepeng yj-liuzepeng requested a review from btea August 27, 2023 01:27
Copy link
Collaborator

@btea btea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@btea btea merged commit cea00f0 into element-plus:dev Aug 28, 2023
10 checks passed
@element-bot element-bot mentioned this pull request Sep 14, 2023
3 tasks
consultation-applio pushed a commit to consultation-applio/element-plus that referenced this pull request Nov 10, 2023
* fix(components): [rate] bind the textColor property

* add test case

* add test case

* Update rate.test.tsx

* Update rate.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Component] [rate] Invalid el rate component after setting text color property
3 participants