refactor(components): [collapse] replace keypress with keydown
#14137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
🧪 Playground Preview: https://element-plus.run/?pr=14137 |
HeftyKoo
approved these changes
Aug 29, 2023
tolking
approved these changes
Aug 29, 2023
consultation-applio
pushed a commit
to consultation-applio/element-plus
that referenced
this pull request
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure these boxes are checked before submitting your PR, thank you!
devbranch.Description
keypresshas been deprecated.https://developer.mozilla.org/en-US/docs/Web/API/Element/keypress_event
🤖 Generated by Copilot at 71737a9
Replaced
@keypresswith@keydownincollapse-item.vueto fix accessibility issue. This change makes the component more compatible with screen readers and modern browsers.Related Issue
Fixes #___.
Explanation of Changes
🤖 Generated by Copilot at 71737a9
@keypressevent listener with@keydownto improve accessibility and compatibility with screen readers (link). This fixes issue [Feature Request] compatible tsx #2244 reported by user @jessica-chen.