Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(components): [date-picker] add aria-labels to date picker btns #14149

Merged
merged 1 commit into from
Sep 8, 2023
Merged

refactor(components): [date-picker] add aria-labels to date picker btns #14149

merged 1 commit into from
Sep 8, 2023

Conversation

Karolis-Stoncius
Copy link
Contributor

@Karolis-Stoncius Karolis-Stoncius commented Aug 29, 2023

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

Description

🤖 Generated by Copilot at e50ade5

Improve accessibility of date range picker by adding aria-label attributes to navigation buttons. Use t function to localize aria-label values.

Related Issue

Fixes #___.

Explanation of Changes

🤖 Generated by Copilot at e50ade5

  • Add aria-label attributes to the navigation buttons in the date range picker component to improve accessibility and usability for screen reader and keyboard users (link, link, link, link, link, link, link, link) in panel-date-range.vue

@pull-request-triage
Copy link

👋 @Karolis-Stoncius, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@github-actions
Copy link

Hello @Karolis-Stoncius, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link

github-actions bot commented Aug 29, 2023

@github-actions
Copy link

🧪 Playground Preview: https://element-plus.run/?pr=14149
Please comment the example via this playground if needed.

Copy link
Collaborator

@btea btea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tolking tolking merged commit c7021b3 into element-plus:dev Sep 8, 2023
13 checks passed
@element-bot element-bot mentioned this pull request Sep 14, 2023
3 tasks
consultation-applio pushed a commit to consultation-applio/element-plus that referenced this pull request Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants