Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components): [color-picker] first click should be trigger #14209

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

wonderl17
Copy link
Contributor

@wonderl17 wonderl17 commented Sep 6, 2023

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

Description

🤖 Generated by Copilot at 5b1462e

Refactor and optimize color picker component. Use v-show instead of v-if for empty icon in color-picker.vue to avoid unnecessary rendering.

Related Issue

Fixes #14205.

Explanation of Changes

🤖 Generated by Copilot at 5b1462e

  • Improve performance and user experience of color picker component by using v-show instead of v-if for empty icon (link)

@pull-request-triage
Copy link

👋 @wonderl17, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@github-actions
Copy link

github-actions bot commented Sep 6, 2023

Hello @wonderl17, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link

github-actions bot commented Sep 6, 2023

@wonderl17
Copy link
Contributor Author

第一次点击由于先走 v-click-outside 的逻辑,会导致 icon 在那一瞬间被 v-if="false"消除后再出现,那一刻恰好无法触发click

@github-actions
Copy link

github-actions bot commented Sep 6, 2023

🧪 Playground Preview: https://element-plus.run/?pr=14209
Please comment the example via this playground if needed.

@HeftyKoo HeftyKoo merged commit 82e9d07 into element-plus:dev Sep 8, 2023
13 checks passed
@element-bot element-bot mentioned this pull request Sep 14, 2023
3 tasks
consultation-applio pushed a commit to consultation-applio/element-plus that referenced this pull request Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants