fix(components): [tabs] Fix some events accidentally firing #14224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 @Mario34, thank you for contributing element-plus.
|
|
|
github-actions
bot
added
Contribution::Community
CommitMessage::Qualified
|
🧪 Playground Preview: https://element-plus.run/?pr=14224 |
Mario34
force-pushed
the
mario34/fix-tabs-event
branch
from
5fdc290
to
b12d25a
Compare
HeftyKoo
approved these changes
Sep 18, 2023
tolking
approved these changes
Sep 18, 2023
btea
approved these changes
Sep 19, 2023
consultation-applio
pushed a commit
to consultation-applio/element-plus
that referenced
this pull request
Nov 10, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14222
Description
🤖 Generated by Copilot at 5fdc290
Refactored
setCurrentNamefunction intabs.tsxto simplify logic and fix event emission bug.Related Issue
Fixes #14222
Explanation of Changes
🤖 Generated by Copilot at 5fdc290
changeCurrentNamefunction and move its logic tosetCurrentName(link)triggerparameter tosetCurrentNameto control whether to emit events (link, link)triggerparameter to allowbeforeLeavehook to prevent events if it returns false (link)trueastriggerparameter when user clicks on a tab inhandleTabClick(link)