Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): row-class-name bgColor can not cover fixed column #14225

Merged
merged 1 commit into from
Sep 18, 2023
Merged

fix(components): row-class-name bgColor can not cover fixed column #14225

merged 1 commit into from
Sep 18, 2023

Conversation

StephenKe
Copy link
Contributor

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

Description

fix table row-class-name can not cover fixed column

Related Issue

Fixes #13130

Explanation of Changes

table-fixed-column background should inherit from parentEl

@pull-request-triage
Copy link

👋 @StephenKe, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@github-actions
Copy link

github-actions bot commented Sep 7, 2023 •
edited

@github-actions
Copy link

github-actions bot commented Sep 7, 2023

Hello @StephenKe, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link

github-actions bot commented Sep 7, 2023

🧪 Playground Preview: https://element-plus.run/?pr=14225
Please comment the example via this playground if needed.

@btea btea requested a review from YunYouJun September 17, 2023 01:36
@YunYouJun YunYouJun merged commit 1601369 into element-plus:dev Sep 18, 2023
12 checks passed
@tolking
Copy link
Member

tolking commented Sep 30, 2023

I found that this PR can cause ElTable style errors in dark mode, BUG

tolking added a commit that referenced this pull request Oct 1, 2023
@tolking
Revert "fix(components): row-class-name bgColor can not cover fixed c…
8cb5794 
…olumn (#14225)"

This reverts commit 1601369.
@YunYouJun YunYouJun mentioned this pull request Oct 3, 2023
Merged
3 tasks
@element-bot element-bot mentioned this pull request Oct 13, 2023
Merged
3 tasks
consultation-applio pushed a commit to consultation-applio/element-plus that referenced this pull request Nov 10, 2023
@StephenKe @dannyhebertbell
fix(components): row-class-name bgColor can not cover fixed column (e…
99b74ea 
…lement-plus#14225)
@TimZhang2090 TimZhang2090 mentioned this pull request Nov 17, 2023
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YunYouJun YunYouJun YunYouJun approved these changes

Assignees

@StephenKe StephenKe

Labels
CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Component] [table, table-column] Fixed column style overrides row-class-name styles
3 participants
@StephenKe @tolking @YunYouJun