Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(components): watermark component #14236

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

TomatoDroid
Copy link
Contributor

@TomatoDroid TomatoDroid commented Sep 8, 2023

be able to set text,multi-text,image as watermark

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

Description

🤖 Generated by Copilot at f245ac4

This pull request adds a new Watermark component to the element-plus package, which allows users to add a watermark effect to any element with text or image content. The pull request includes the component code, types, hooks, utils, and tests, as well as the documentation and examples for the component. The component is imported and exported in the component.ts file and the documentation sidebar is updated in the component.json file.

Related Issue

Fixes #___.

Explanation of Changes

🤖 Generated by Copilot at f245ac4

  • Add a new Watermark component to the element-plus package, which allows users to add a watermark effect to any element (link, link, link, link, link, link, link, link, link, link, link, link)
  • Add a link and text for the Watermark component in the component.json file, which generates the documentation sidebar for the component library (link)
  • Add a unit test for the Watermark component using vite and vue-test-utils, which tests the component's creation and slots (link)

@pull-request-triage
Copy link

👋 @TomatoDroid, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@pull-request-triage pull-request-triage bot added 1st contribution Their very first contribution Needs Review labels Sep 8, 2023
@github-actions
Copy link

github-actions bot commented Sep 8, 2023

Hello @TomatoDroid, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link

github-actions bot commented Sep 8, 2023

@btea
Copy link
Collaborator

btea commented Sep 8, 2023

You shouldn't commit the pnpm-lock.yaml file.

be able to set text,multi-text,image as watermark
@github-actions
Copy link

github-actions bot commented Sep 8, 2023

🧪 Playground Preview: https://element-plus.run/?pr=14236
Please comment the example via this playground if needed.

@TomatoDroid
Copy link
Contributor Author

You shouldn't commit the pnpm-lock.yaml file.

I solved it。

Copy link
Member

@ryuhangyeong ryuhangyeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@btea

Do we accept new components?

This is a good thing, but we need some design guide (ex. figma)

@btea
Copy link
Collaborator

btea commented Sep 9, 2023

I agree, this component looks great. What do you think? cc @element-plus/backers

@kooriookami
Copy link
Member

This a nice component, we should accept it after reviewed.

Copy link
Member

@YunYouJun YunYouJun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dynamic example is well done.

@kooriookami kooriookami merged commit 7916200 into element-plus:dev Oct 10, 2023
10 checks passed
@element-bot element-bot mentioned this pull request Oct 13, 2023
3 tasks
cc-hearts pushed a commit to cc-hearts/element-plus that referenced this pull request Oct 15, 2023
* feat(components): watermark component

be able to set text,multi-text,image as watermark

* docs(components): update image watermark example

update the image for dark mode
consultation-applio pushed a commit to consultation-applio/element-plus that referenced this pull request Nov 10, 2023
* feat(components): watermark component

be able to set text,multi-text,image as watermark

* docs(components): update image watermark example

update the image for dark mode
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants