fix(components): [menu] export MenuInstance #14284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
🧪 Playground Preview: https://element-plus.run/?pr=14284 |
ryuhangyeong
approved these changes
Sep 14, 2023
|
Maybe we can create a separate instance.ts file-like button. |
btea
approved these changes
Sep 15, 2023
consultation-applio
pushed a commit
to consultation-applio/element-plus
that referenced
this pull request
Nov 10, 2023
* fix(components): [menu] export MenuInstance closed element-plus#14251 * chore: export other component instance * refactor: extract instace type to instance file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please make sure these boxes are checked before submitting your PR, thank you!
close #14251
devbranch.Description
🤖 Generated by Copilot at 1c784a4
This pull request refactors the menu component and its subcomponents to use a consistent naming convention and export their types. This makes the menu component easier to use and bundle with TypeScript.
Related Issue
Fixes #___.
Explanation of Changes
🤖 Generated by Copilot at 1c784a4
ElMenuand export it as a named export (link)