fix(components): [collapse] fix triggering form action when inside it #14308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When el-collapse with el-collapse-item is placed inside a form and the collapse trigger btn is pressed, form's action as triggered. This fixes it closed element-plus#14304
|
👋 @Karolis-Stoncius, thank you for contributing element-plus.
|
|
Hello @Karolis-Stoncius, thank you for contributing to element-plus, please see our guideline to see how to make contribution |
|
|
|
🧪 Playground Preview: https://element-plus.run/?pr=14308 |
btea
approved these changes
Sep 16, 2023
ryuhangyeong
approved these changes
Sep 17, 2023
tolking
approved these changes
Sep 17, 2023
|
@ryuhangyeong when release with this fix? |
|
It is expected to be released within two weeks, but this is not exact. |
This was referenced Oct 7, 2023
consultation-applio
pushed a commit
to consultation-applio/element-plus
that referenced
this pull request
Nov 10, 2023
…element-plus#14308) When el-collapse with el-collapse-item is placed inside a form and the collapse trigger btn is pressed, form's action as triggered. This fixes it closed element-plus#14304
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When el-collapse with el-collapse-item is placed inside a form and the collapse trigger btn is pressed, form's action as triggered. This fixes it
closed #14304
Please make sure these boxes are checked before submitting your PR, thank you!
devbranch.Description
🤖 Generated by Copilot at 211e315
Added
typeattribute toel-buttonincollapse-itemcomponent to prevent form submission. This fixes a bug reported in issue #14304.Related Issue
Fixes #14304.
Explanation of Changes
🤖 Generated by Copilot at 211e315
typeattribute toel-buttoncomponent to prevent form submission on click (link)