Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): [form] label-position type error #14312

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

btea
Copy link
Collaborator

@btea btea commented Sep 17, 2023

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

Description

🤖 Generated by Copilot at 8cfabef

Added type annotation for labelPosition ref in form alignment example. This improves type safety and developer experience when using the ElForm component.

Related Issue

Fixes #___.

Explanation of Changes

🤖 Generated by Copilot at 8cfabef

  • Annotate labelPosition ref with FormProps['labelPosition'] type for better type checking and code completion (link)

@github-actions
Copy link

github-actions bot commented Sep 17, 2023

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Sep 17, 2023
@github-actions
Copy link

🧪 Playground Preview: https://element-plus.run/?pr=14312
Please comment the example via this playground if needed.

@btea btea merged commit 5ebce79 into dev Sep 18, 2023
13 checks passed
@btea btea deleted the fix/form-docs-label-position-type branch September 18, 2023 00:55
@element-bot element-bot mentioned this pull request Oct 13, 2023
3 tasks
consultation-applio pushed a commit to consultation-applio/element-plus that referenced this pull request Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CommitMessage::Qualified Qualified commit message
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants