Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): [select-v2] read properties of null #14321

Merged
merged 2 commits into from
Oct 8, 2023
Merged

fix(components): [select-v2] read properties of null #14321

merged 2 commits into from
Oct 8, 2023

Conversation

FrontEndDog
Copy link
Member

@FrontEndDog FrontEndDog commented Sep 18, 2023 •
edited by ghost

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

Description

🤖 Generated by Copilot at b57357e

Add null check for menuRef.value in useSelect.ts to avoid error. This improves the stability of the select component in filterable mode.

Related Issue

Fixes #14316 .

Explanation of Changes

🤖 Generated by Copilot at b57357e

  • Add a null check for menuRef.value before calling nextTick to prevent errors (link)

@pull-request-triage
Copy link

👋 @FrontEndDog, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@pull-request-triage pull-request-triage bot added 1st contribution Their very first contribution Needs Review labels Sep 18, 2023
@github-actions
Copy link

github-actions bot commented Sep 18, 2023 •
edited

@github-actions
Copy link

Hello @FrontEndDog, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link

github-actions bot commented Sep 18, 2023 •
edited

🧪 Playground Preview: https://element-plus.run/?pr=14321
Please comment the example via this playground if needed.

btea
btea approved these changes Oct 8, 2023
View reviewed changes
Copy link
Collaborator

@btea btea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@btea btea merged commit 8281fa9 into element-plus:dev Oct 8, 2023
10 checks passed
@element-bot element-bot mentioned this pull request Oct 13, 2023
Merged
3 tasks
cc-hearts pushed a commit to cc-hearts/element-plus that referenced this pull request Oct 15, 2023
@FrontEndDog @cc-hearts
fix(components): [select-v2] read properties of null (element-plus#14321
16eb7c2 
)
consultation-applio pushed a commit to consultation-applio/element-plus that referenced this pull request Nov 10, 2023
@FrontEndDog @dannyhebertbell
fix(components): [select-v2] read properties of null (element-plus#14321
c81f0d9 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tolking tolking tolking approved these changes

@btea btea btea approved these changes

Assignees

@FrontEndDog FrontEndDog

Labels
1st contribution Their very first contribution CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
3 participants
@FrontEndDog @tolking @btea