fix(components): [checkbox] indeterminate checkbox a11y fix #14322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 @Karolis-Stoncius, thank you for contributing element-plus.
|
|
Hello @Karolis-Stoncius, thank you for contributing to element-plus, please see our guideline to see how to make contribution |
|
|
|
This is the same PR as this, I had to delete my fork, so I created a new PR. |
|
🧪 Playground Preview: https://element-plus.run/?pr=14322 |
btea
approved these changes
Sep 28, 2023
|
@btea when will this be merged and released? |
|
Don't worry, it still needs to be reviewed and confirmed by others. |
tolking
approved these changes
Oct 12, 2023
cc-hearts
pushed a commit
to cc-hearts/element-plus
that referenced
this pull request
Oct 15, 2023
consultation-applio
pushed a commit
to consultation-applio/element-plus
that referenced
this pull request
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bunch of a11y issues when a checkbox is indeterminate. Here's a playground , select one of the items and scan for a11y issues (I'm using axe DevTools). This PR fixes these a11y issues caused by an indeterminate checkbox:
https://dequeuniversity.com/rules/axe/4.7/aria-hidden-focus?application=AxeChrome
https://dequeuniversity.com/rules/axe/4.7/aria-toggle-field-name?application=AxeChrome
https://dequeuniversity.com/rules/axe/4.7/nested-interactive?application=AxeChrome
Please make sure these boxes are checked before submitting your PR, thank you!
devbranch.Description
🤖 Generated by Copilot at d7683ca
Improve checkbox component accessibility and functionality. Use native
indeterminateattribute and remove unnecessary attributes fromspanandinputelements incheckbox.vue.Related Issue
Fixes #___.
Explanation of Changes
🤖 Generated by Copilot at d7683ca
indeterminateattribute to input element for partial selection state (link, link)aria-hiddenattribute from input element to avoid accessibility issues (link, link)