Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(components): [ColorPicker] add slot custom trigger #14326

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

lequangdongg
Copy link
Contributor

@lequangdongg lequangdongg commented Sep 18, 2023

Please make sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow contributing guide English | (中文 | Español | Français).
  • Make sure you are merging your commits to dev branch.
  • Add some descriptions and refer to relative issues for your PR.

Description

  • With color picker, i i want a custom default trigger with any element

🤖 Generated by Copilot at fbd6d5c

This pull request enhances the color-picker component by adding a trigger slot and removing unused icons. The trigger slot lets users customize the color-picker trigger element in color-picker.vue.

Related Issue

Fixes #___.

Explanation of Changes

🤖 Generated by Copilot at fbd6d5c

  • Add a trigger slot to the color-picker component to allow customizing the trigger element (link)
  • Remove unused imports of ArrowDown and Close icons from the @element-plus/icons-vue package (link)

@pull-request-triage
Copy link

👋 @lequangdongg, thank you for contributing element-plus.

  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@github-actions
Copy link

github-actions bot commented Sep 18, 2023

@github-actions
Copy link

Hello @lequangdongg, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link

github-actions bot commented Sep 18, 2023

🧪 Playground Preview: https://element-plus.run/?pr=14326
Please comment the example via this playground if needed.

@lequangdongg lequangdongg changed the title feat: [ColorPicker] add slot custom trigger feat(components): [ColorPicker] add slot custom trigger Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant