Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(MessageBox): unused keyframe #14335

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Conversation

zhousg
Copy link
Contributor

@zhousg zhousg commented Sep 19, 2023

No description provided.

@pull-request-triage
Copy link

馃憢 @zhousg, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@pull-request-triage pull-request-triage bot added 1st contribution Their very first contribution Needs Review labels Sep 19, 2023
@github-actions
Copy link

github-actions bot commented Sep 19, 2023

@github-actions
Copy link

Hello @zhousg, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions github-actions bot added the CommitMessage::Qualified Qualified commit message label Sep 25, 2023
@github-actions
Copy link

馃И Playground Preview: https://element-plus.run/?pr=14335
Please comment the example via this playground if needed.

@btea btea requested a review from YunYouJun September 27, 2023 01:08
@YunYouJun
Copy link
Member

Yeah, it's unused.

Just for more information:

We use msgbox-fade-in reverse instead of msgbox-fade-out.

animation: msgbox-fade-in getCssVar('transition-duration') reverse;

@YunYouJun YunYouJun merged commit 8d28ee4 into element-plus:dev Oct 3, 2023
12 checks passed
@zhousg zhousg deleted the zhousg-patch-1 branch October 4, 2023 02:02
@element-bot element-bot mentioned this pull request Oct 13, 2023
3 tasks
consultation-applio pushed a commit to consultation-applio/element-plus that referenced this pull request Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants