Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(components): [form-item]Label attribute for judging modification #14344

Merged
merged 1 commit into from
Sep 21, 2023
Merged

feat(components): [form-item]Label attribute for judging modification #14344

merged 1 commit into from
Sep 21, 2023

Conversation

Xaw-xu
Copy link
Contributor

@Xaw-xu Xaw-xu commented Sep 20, 2023 •
edited by HeftyKoo

Please make sure these boxes are checked before submitting your PR, thank you!
close #14341

  • [√] Make sure you follow contributing guide English | (中文 | Español | Français).
  • [√] Make sure you are merging your commits to dev branch.
  • [√] Add some descriptions and refer to relative issues for your PR.

Description

el-form-item组件的for属性如果传入了需要用传入的，组件内部判断有些问题，对此问题的修复#14341

🤖 Generated by Copilot at 27f5c29

Reformatted code in form-item.vue for readability and style.

Related Issue

Fixes #___.

Explanation of Changes

🤖 Generated by Copilot at 27f5c29

  • Wrap ternary expression in parentheses for better readability and consistency (link)

@pull-request-triage
Copy link

👋 @Xaw-xu, seems like this is your first time contribution to element-plus.

  • Please make sure that you have read our guidelines and code of conduct before making a contribution.
  • You can comment with /label Components:[component_name] to add a label for which component you are working on.
  • You may join our Discord for staying tuned.

@pull-request-triage pull-request-triage bot added 1st contribution Their very first contribution Needs Review labels Sep 20, 2023
@github-actions
Copy link

github-actions bot commented Sep 20, 2023 •
edited

@github-actions
Copy link

Hello @Xaw-xu, thank you for contributing to element-plus, please see our guideline to see how to make contribution

@github-actions
Copy link

🧪 Playground Preview: https://element-plus.run/?pr=14344
Please comment the example via this playground if needed.

HeftyKoo
HeftyKoo approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@HeftyKoo HeftyKoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@HeftyKoo HeftyKoo merged commit 99e8736 into element-plus:dev Sep 21, 2023
13 checks passed
@element-bot element-bot mentioned this pull request Oct 13, 2023
Merged
3 tasks
consultation-applio pushed a commit to consultation-applio/element-plus that referenced this pull request Nov 10, 2023
@Xaw-xu @dannyhebertbell
feat(components): [form-item]Label attribute for judging modification (…
b63f8ee 
…element-plus#14344)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeftyKoo HeftyKoo HeftyKoo approved these changes

@chenxch chenxch chenxch approved these changes

Assignees

@Xaw-xu Xaw-xu

Labels
1st contribution Their very first contribution CommitMessage::Qualified Qualified commit message Contribution::Community Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TypeScript] [form-item] form-item的for属性没用
3 participants
@Xaw-xu @HeftyKoo @chenxch